search

codeuino / social-platform-donut-backend

Donut API:
http://donut-api-prod.codeuino.org/
GNU General Public License v3.0
24 stars 57 forks source link

Activate account functionality through email template #122

Closed Rupeshiya closed 4 years ago

Rupeshiya commented 4 years ago

name: Pull Request template about: Describe the PR. title: '' labels: '' assignees: ''

Problem

Github Issue Number: #83 and #120

  1. When user will register on the platform then they will receive the email for activating their account, so when they will click on activate account button then their account will gets activated_
  2. Test cases of url shortener updated

    Solution of problem

    Activate account through link sent in email template

Type of Change

[ ] Bug fix [✓] New Feature [ ] Development of UI/UX prototypes [✓] Small refactor [ ] Change in Documentation

Checklist

[✓ ] My code follows the same style as the codebase [ ] My Code change requires a change in documentation [ ] I have updated the Readme accordingly [✓ ] I made PR against development branch [✓ ] I have run the test cases locally and it's passing. [ ] I have squashed my commits

Rupeshiya commented 4 years ago

@devesh-verma @vaibhavdaren @ayushnagar123 Please review

codecov[bot] commented 4 years ago

Codecov Report

Merging #122 into development will increase coverage by 2.22%. The diff coverage is 75.67%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #122      +/-   ##
===============================================
+ Coverage        68.44%   70.66%   +2.22%     
===============================================
  Files               26       27       +1     
  Lines              675      692      +17     
  Branches            93       96       +3     
===============================================
+ Hits               462      489      +27     
+ Misses             190      182       -8     
+ Partials            23       21       -2
Impacted Files Coverage Δ
app/models/UrlShortner.js 100.00% <ø> (ø)
app/routes/urlShortner.js 100.00% <ø> (ø)
app/controllers/urlShortner.js 57.69% <64.28%> (+42.87%) :arrow_up:
app/controllers/user.js 58.33% <66.66%> (+1.19%) :arrow_up:
app/controllers/email.js 87.50% <87.50%> (ø)
app/routes/user.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db5ccda...0dd15ae. Read the comment docs.