codeuino / social-platform-donut-backend

Donut API:
http://donut-api-prod.codeuino.org/
GNU General Public License v3.0
24 stars 57 forks source link

Fixes issues in testing #160

Closed ksraj123 closed 4 years ago

ksraj123 commented 4 years ago

Problem

Github Issue Number: #152 , #161

Solution of problem

Issue 152

Issue 161

Type of Change

Checklist

ksraj123 commented 4 years ago

@Rupeshiya @AuraOfDivinity @devesh-verma Please review

Rupeshiya commented 4 years ago

Hi @ksraj123, Could you please run the test case locally and add the screenshot here?

ksraj123 commented 4 years ago

@Rupeshiya Sure, Here it is. Screenshot from 2020-07-29 02-28-50

Rupeshiya commented 4 years ago

Cool, Looks fine!!

AuraOfDivinity commented 4 years ago

Looks good for me!

ksraj123 commented 4 years ago
codecov[bot] commented 4 years ago

Codecov Report

Merging #160 into development will decrease coverage by 5.33%. The diff coverage is 55.45%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #160      +/-   ##
===============================================
- Coverage        68.85%   63.51%   -5.34%     
===============================================
  Files               26       46      +20     
  Lines              687     1472     +785     
  Branches            94      180      +86     
===============================================
+ Hits               473      935     +462     
- Misses             191      477     +286     
- Partials            23       60      +37     
Impacted Files Coverage Δ
app/controllers/auth.js 83.33% <ø> (-2.39%) :arrow_down:
app/middleware/auth.js 93.33% <ø> (ø)
app/models/Event.js 61.90% <ø> (ø)
app/models/Organisation.js 55.55% <ø> (ø)
app/models/Post.js 66.66% <ø> (ø)
app/models/Project.js 60.00% <ø> (ø)
app/models/UrlShortner.js 100.00% <ø> (ø)
app/routes/index.js 83.33% <ø> (+8.33%) :arrow_up:
app/routes/urlShortner.js 100.00% <ø> (ø)
app/utils/response-helper.js 37.50% <0.00%> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48e8523...ab05538. Read the comment docs.