Closed ksraj123 closed 4 years ago
@Rupeshiya @AuraOfDivinity @devesh-verma Please review
Hi @ksraj123, Could you please run the test case locally and add the screenshot here?
@Rupeshiya Sure, Here it is.
Cool, Looks fine!!
Looks good for me!
EADDRINUSE Issue fixed for all routes
Issues in proposal route fixed
Fixed issues with org route
All test cases passing
Merging #160 into development will decrease coverage by
5.33%
. The diff coverage is55.45%
.
@@ Coverage Diff @@
## development #160 +/- ##
===============================================
- Coverage 68.85% 63.51% -5.34%
===============================================
Files 26 46 +20
Lines 687 1472 +785
Branches 94 180 +86
===============================================
+ Hits 473 935 +462
- Misses 191 477 +286
- Partials 23 60 +37
Impacted Files | Coverage Δ | |
---|---|---|
app/controllers/auth.js | 83.33% <ø> (-2.39%) |
:arrow_down: |
app/middleware/auth.js | 93.33% <ø> (ø) |
|
app/models/Event.js | 61.90% <ø> (ø) |
|
app/models/Organisation.js | 55.55% <ø> (ø) |
|
app/models/Post.js | 66.66% <ø> (ø) |
|
app/models/Project.js | 60.00% <ø> (ø) |
|
app/models/UrlShortner.js | 100.00% <ø> (ø) |
|
app/routes/index.js | 83.33% <ø> (+8.33%) |
:arrow_up: |
app/routes/urlShortner.js | 100.00% <ø> (ø) |
|
app/utils/response-helper.js | 37.50% <0.00%> (ø) |
|
... and 56 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 48e8523...ab05538. Read the comment docs.
Problem
Github Issue Number: #152 , #161
Solution of problem
Issue 152
beforeEach
, this caused an mongoose error, addedawait
toasync
taskexpect
the right status code, redirection gives 302Issue 161
GET /user/invite
expected role in query string but the test did not provide any, due to this the decrypted token in the controller ofGET /user/invite/:token
did not had a role property which caused it to return 400app.js
to startserver
only when the environment is nottesting
, which was causing this issuePOST /proposal
to not have organization property as well which was the reason for the test failing. Added the organization property to Proposal schema but did not made it required to ensure something else does not break due to this.beforeAll
but did not close it inafterAll
which was causing this issue.Type of Change
Checklist