search

codeuino / social-platform-donut-backend

Donut API:
http://donut-api-prod.codeuino.org/
GNU General Public License v3.0
24 stars 57 forks source link

212 #213

Closed kaustubhai closed 3 years ago

kaustubhai commented 3 years ago

Problem

Github Issue Number: #212 Personal Overview was giving out the wrong information on the number of event and project created

Solution of problem

Modified the function and used proper methods to count the correct number

Type of Change

[x] Bugfix [ ] New Feature [ ] Development of UI/UX prototypes [ ] Small refactor [ ] Change in Documentation

Checklist

[x] My code follows the same style as the codebase [ ] My Code change requires a change in documentation [ ] I have updated the Readme accordingly [x] I made PR against development branch [x] I have run the test cases locally and it's passing. [x] I have squashed my commits

ksraj123 commented 3 years ago

@kaustubhai Please remove package-lock.json from all of your PRs.

kaustubhai commented 3 years ago

Sorry. Must have missed it in that one. Deleted

ksraj123 commented 3 years ago

@kaustubhai Why is this PR so massive now? 9799 deletions? Have you completely deleted the package-lock.json file? Just do not track changes to package-lock.json. Not include it in your PRs.

kaustubhai commented 3 years ago

@ksraj123 So now should I copy the lock.json from main repo and send another PR?

ksraj123 commented 3 years ago

@kaustubhai I see that your PR uses commits from other PRs. This is not the best way to do things. I would suggest you to close all the PRs which depend upon changes made in your first PR and wait for that to be merged first.