search

codeuino / social-platform-donut-backend

Donut API:
http://donut-api-prod.codeuino.org/
GNU General Public License v3.0
24 stars 57 forks source link

Thirdy Party Authentication with passport #57

Closed harshithpabbati closed 4 years ago

harshithpabbati commented 4 years ago

Frontend part: https://github.com/codeuino/social-platform-donut-frontend/pull/342

devesh-verma commented 4 years ago

@harshithpabbati dont hardcode failure redirect to localhost:3000, because when this goes to production there will be no localhost and this will fail. I feel it should be '/' which is where we have login.

devesh-verma commented 4 years ago

@harshithpabbati also, please check why travis is failing.

devesh-verma commented 4 years ago

@harshithpabbati also, the login which you have added to app/routes/index.js should be move to auth

devesh-verma commented 4 years ago

@harshithpabbati hey can you please resolve the conflict.

devesh-verma commented 4 years ago

@harshithpabbati hey are you still willing to work on this?