search

codeunion / examples-sinatra

A repository of example Sinatra apps illustrating common patterns in web development
3 stars 16 forks source link

Minor misspellings in authentication forms. #4

Open dwhite96 opened 10 years ago

dwhite96 commented 10 years ago

There is a minor misspelling in sessions_new.erb; line 6 says, "Ut oh!" and also users_new.erb line 6.

In index.erb line 10 says, 'It doesn't "looked" like you're signed in.'

jcdavison commented 10 years ago

Hi David,

Not that I am asking you to do our 'bug fixing' cause I can certainly do it, but are you familiar with how to fork, edit, commit and then issue a pull request with said code changes? This is a solid bug fix to practice those behaviors on.

Just a thought, let me know please if you aren't up for it and I will make the changes.

dwhite96 commented 10 years ago

Sure, I can do that. I was wondering if I should just go ahead and fix it myself and do a pull request.

jcdavison commented 10 years ago

It would be cool, but do you already know how to do what I've described above? If you do, don't worry, I will make the code fix myself.

dwhite96 commented 10 years ago

I haven't done a pull request yet, but would like to for practice. I'm giving it a try right now.

jcdavison commented 10 years ago

Cool, this is great practice on a topic that can be a little difficult.