search

codevision-org / codevision-web

The website for the Codevision organization.
https://codevision.org
MIT License
0 stars 0 forks source link

Used some js to make the the world "Course" append the 's' character … #13

Closed Technerder closed 5 years ago

Technerder commented 5 years ago

…if the user has created more than 1 course. (Untested)

presidentennn commented 5 years ago

Doesn't make a lot of sense to me.

Technerder commented 5 years ago

It uses a tertiary operator to append an 's' to the end of the word 'Course'

So:

The first number being the amount of courses the user has.

0 : '0 Courses' 1 : '1 Course' 2 : '2 Courses'

and so on.

presidentennn commented 5 years ago

Well, I understood that, but I was wondering why we need this. I'm assuming you want to avoid the "1 Course" text appearing (which is wrong grammatically)?

timtomtim7 commented 5 years ago

Well, I understood that, but I was wondering why we need this. I'm assuming you want to avoid the "1 Course" text appearing (which is wrong grammatically)?

Well, it's definitely not meant to be "1 Courses" or "2 Course"

presidentennn commented 5 years ago

It's not supposed to be a number before "Course(s)" so I'm not sure where you got that from. A better idea would be to have the text "Courses (5)" which follows the format from other places (for example the courses/show page.

Technerder commented 5 years ago

I personally believe that '5 Courses' is better than 'Courses (5)', and I feel like quite a few others feel the same.

presidentennn commented 5 years ago

"Courses", "Comments" and "Sections" are supposed to be subtitles. It would make much more sense if this format below was written everywhere (it already exists on most pages) instead of having mixed formats. image

timtomtim7 commented 5 years ago

I wasn't paying attention to where it was on the page, sorry.

Technerder commented 5 years ago

Fair point.