search

codewario / PocketLibraryImages

This tool will prepare an image library for use with cartridges (and openFPGA cores if Analogue ever supports them) on Analogue OS
MIT License
110 stars 1 forks source link

Some libretro-thumbnails images are jpegs with a .png extension #6

Closed codewario closed 1 year ago

codewario commented 1 year ago

Only a small number of these (can count on one hand at this time of writing across GB/GBC/GBA/GG) have been detected and caused some headaches while addressing #5. I've coded in the ability to detect these JPEGs, but as they don't throw any errors during the conversion process, and the games this happens for I don't own, I am unable to confirm whether or not these JPEGs are being properly converted to the Analogue format or not.

I will probably close this once I have the code committed, but may revisit it it's confirmed the image conversion doesn't work for these edge cases. My hypothesis is that the libraries I'm using recognize the jpeg header+footer and load it in regardless of the extension prior to the conversion, but it was also happy to do this for the symlinked text files which resulted in no image output on the Game Details screen, so I'm not really certain on this one.

codewario commented 1 year ago

New code (not yet committed) writes output alerting when it comes across one of these, but currently continues the conversion as normal.

codewario commented 1 year ago

This has been completed, a warning is produced when these are encountered but otherwise continues the conversion process as normal. I cannot validate these title revisions myself so I'm still not sure whether or not these converted images display correctly, or at all, on the Analogue Pocket (feedback here is welcome).