Voileexperiments commented 6 years ago

This has occurred to this translation of this kata:

Translation approvals does not seem to handle race conditions properly. If two separate users approve the same translation at once, it'll end up being approved twice and now we have 2 versions of the same language.

┆Issue is synchronized with this Clickup by Unito

Voileexperiments commented 6 years ago

Related: #1009

Voileexperiments commented 6 years ago

This is happening again:

https://www.codewars.com/kata/scytale-encoder-slash-decoder-ancient-spartans-cipher

There are 2 JS language versions. Incidentally, it also causes JS version edits to fail to be applied.

hobovsky commented 5 years ago

Two C versions: https://www.codewars.com/kata/square-matrix-multiplication

10XL commented 5 years ago

2 Ruby versions https://www.codewars.com/kata/split-and-then-add-both-sides-of-an-array-together

Voileexperiments commented 5 years ago

Is this related to #1683?

kazk commented 5 years ago

Not related to #1683, but the same idea. Bugs from race conditions like this unavoidable unless the data integrity is enforced at the database level.

1683 shouldn't happen if proper unique index was there (user will always have one document per kata because write will fail on attempt to add a document that violates the condition). To be honest, I'm not sure why that's happening to begin with because that should only involve one user. But the ORM is making implicit database calls all the time so it's probably just something hidden.

This one is embedded document so unique index (within the document embedded in) is not even supported. So I'm not really sure what to do.

MongoDB is obviously not great for relational data and it's very difficult (or just needs more work) to maintain data integrity. I wish Codewars used PostgreSQL, but it is what it is.

Voileexperiments commented 5 years ago

If kata data is structured like what I can see from the editor publish requests I think you can do this, just need to add an extra key to all the available languages as strings per kata.

kazk commented 5 years ago

@Voileexperiments thanks, yeah, something like that should minimize the risk.

Languages are embedded in kata and it has "name" key.

{
  name: "Multiply",
  languages: [
    {
      name: "javascript"
    }
  ]
}

The ORM should be validating the uniqueness of languages.name locally (so adding another javascript to above will fail), but that's the best they can do.

When a translation is approved we currently do the following to merge a language (after checking description conflict etc).

get the embedded document by language name or initialize one in memory if not found
copy the data from translation into this document
save the kata document

hobovsky commented 5 years ago

Two Java versions: https://www.codewars.com/kata/path-finder-number-4-where-are-you