codewars / codewars.com

Issue tracker for Codewars
https://www.codewars.com
BSD 2-Clause "Simplified" License
2.09k stars 220 forks source link

make it so links directly to the trainer don't automatically start the kata #3079

Open Yarnacle opened 1 year ago

Yarnacle commented 1 year ago

Problem

Currently, when a user clicks on a link to the trainer for a kata, they automatically start the kata. This can be frustrating for the user, as they may have only intended to see the description of the kata instead of starting it.

Current Solution

In the Codewars Discord server, the moderation bot automatically reminds people who post kata trainer links to tell them to change the link so that it links to the kata's description instead of its trainer.

While this solution may be mostly effective in the Codewars Discord server, it does not address kata trainer links that are posted outside of the server (in a blog post, for instance). Plus, it feels like a temporary solution, as it merely addresses a symptom of an underlying problem with sharing kata.

Proposed Solution

If a user tries to access the trainer of a kata without having explicitly started the kata (for example by clicking the "Train" button), redirect them to the description of the kata.

hobovsky commented 1 year ago

It feels like an XY problem. It's not only difficult to handle the problem on the navigation level (it's not easy to know how you entered the trainer page, and it's not easy to decide what to do when you entered the page from an unexpected place), but it also does not target the problem directly. Ideally a kata would not be started just by entering the trainer page, but for example after first TEST or ATTEMPT. Or merely entering the trainer could have no special consequences (no trace left in "Unfinished" kata list), or they could be reversible (for example, a user can remove kata from the "Unfinished" list).

The problem is that the "Unfinished" list gets cluttered, and changing the navigation is just a half-measure.

Blind4Basics commented 1 year ago

Ideally a kata would not be started just by entering the trainer page

Tho, the current behavior about that does make sense, imo.

@Yarnacle; the train button isn't the only "legit" way to enter the trainer. For instance, the languages icons on any list of kata also lead to the related trainers.

Yarnacle commented 1 year ago

@Blind4Basics You're right, I overlooked that. Good catch.

Voileexperiments commented 1 year ago

Though actually, some parts of CW do distinguish between "entered the trainer page" and "made at least a submission (sample tests included)". I think it's exclusive to the "unfinished katas" page in user's own profile.