22 Migrate Color Wheel Activity #22

[innaamogolonova]

Why:

Closes the following issues (all PRs must close an issue):

• closes #22

What's being changed

Simplifies the rainbow() method in act3 examples to implement Lantern.h library, making the function easier to read.

Testing instructions

The easiest way to test is to run the rainbow method in activity 3 which double as testing files.

You can verify that the code works appropriately by visually inspecting the colors that result from the activity function calls.

• [x] The LED goes through the complete color spectrum (red to green to blue back to red)
• [x] The color change is gradual and smooth
• [x] The rainbow lasts the specified "seconds" amount of time
• [x] Change the number of seconds and make sure the rainbow lasts appropriate amount of time

Check off the following

• [x] I have assigned @totally-not-frito-lays as a reviewer

[totally-not-frito-lays]

Just asking for a bit more clarity. The code works well as is really enjoyable to watch.

Something interesting I noted is that when giving invalid input (ie. negative numbers) such as rainbow(-5) the behavior here is different than from CC-Library-Lantern. In CC-Library-Lantern the behavior was rapidly changing colors. In CC-Lantern (this repo), the behavior runs slowly, starting at orange.

This may be a quirk of our implementation of the wait() wrapper function. I'll open up a ticket for this.

Opened ticket #25 for this. Bounds handling inside this function is the easiest way to resolve this for now but it may be worth some exploration to see if this occurs for other functions.

Just to clarify, this PR does not need to resolve #25.

[innaamogolonova]

Addressed the changes requested by:

• commenting out other functions
• adding a bounds check
• adding an explanation for 765 number (both in code and on notion)