Describe the bug
Something interesting I noted in #24 is that when giving invalid input (ie. negative numbers) such as rainbow(-5) the behavior here is different than from CC-Library-Lantern. In CC-Library-Lantern the behavior was rapidly changing colors. In CC-Lantern (this repo), the behavior runs slowly, starting at orange.
This may be a quirk of our implementation of the wait() wrapper function. I'll open up a ticket for this.
Expected behavior
The expected behavior for negative values in the wait() call is to call delay() for 0.25 seconds. This means the colors should cycle through the entire spectrum in 0.25 seconds.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
OS: [e.g. iOS] N/A
Browser [e.g. chrome, safari] N/A
Version [e.g. 22] N/A
Smartphone (please complete the following information):
Device: [e.g. iPhone6] N/A
OS: [e.g. iOS8.1] N/A
Browser [e.g. stock browser, safari] N/A
Version [e.g. 22] N/A
Additional context
The easiest fix is to have bounds handling inside the function itself.
Describe the bug Something interesting I noted in #24 is that when giving invalid input (ie. negative numbers) such as
rainbow(-5)
the behavior here is different than fromCC-Library-Lantern
. InCC-Library-Lantern
the behavior was rapidly changing colors. InCC-Lantern
(this repo), the behavior runs slowly, starting at orange.This may be a quirk of our implementation of the
wait()
wrapper function. I'll open up a ticket for this.To Reproduce Steps to reproduce the behavior:
rainbow(20)
->rainbow(-5)
Expected behavior The expected behavior for negative values in the
wait()
call is to calldelay()
for0.25
seconds. This means the colors should cycle through the entire spectrum in 0.25 seconds.Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context The easiest fix is to have bounds handling inside the function itself.