search

codewithmichael / babel-browser-harness

In-browser CDN-based ES6+ transpiling via Babel
MIT License
1 stars 0 forks source link

Avoid Object.assign() #12

Closed codewithmichael closed 8 years ago

codewithmichael commented 8 years ago

Purpose

While Object.assign() is gaining browser traction, some mobile environments still don't have built-in support for it.

buildModuleEntries() currently uses Object.assign() and this could hurt target audience compatibility.

Proposal

Manually iterate properties and perform a manual copy using for (key in object) {...} and object.hasOwnProperty(key) notation.

codewithmichael commented 8 years ago

PR #13 resolves this issue

codewithmichael commented 8 years ago

As mentioned in the comments on 58cc460, it also addresses this issue. If that branch gets merged into the next release, we don't need PR #13. Otherwise, it can always be merged over later.