codewithmichael / babel-browser-harness

In-browser CDN-based ES6+ transpiling via Babel
MIT License
1 stars 0 forks source link

Config via getters/setters/modifiers #14

Closed codewithmichael closed 8 years ago

codewithmichael commented 8 years ago

Purpose

Registration uses getters and setters to alter it's configuration options, while the rest of the config uses directly modified variables, which in turn requires the dedicated importConfig() method which simply copies the public facing values back inside.

Proposal

Use all getters/setters/modifiers for all configuration items.

codewithmichael commented 8 years ago

This is going to depend on the issue16 branch, as they deal with similar issues and will need some shared code.

codewithmichael commented 8 years ago

As noted in issue #24, the single-path methodology of the config() method from issue #16 is preferable to using setters and modifiers.

Getter methods will likely remain as a means of accessing stored configurations, but will evolve organically and don't require an issue of their own.

Closing as wontfix.