search

codewithpassion / foxglove-studio-h264-extension

POC extension to render h264
MIT License
9 stars 5 forks source link

Added protobuf support #5

Open refck opened 11 months ago

refck commented 11 months ago

Fixed some bugs with the package version conflicts and also fixed the buffer conversion issue. Confirmed Uin8Array.buffer lost some data of the array which makes some NAL unit related process broken. After using Buffer package instead, those data loss situation is gone and also protobuf message could be visualized.

Could you please merge this if you feel okay and push the changes to the extension app on the foxglove extension marketplace?

christian-nils commented 9 months ago

Hi @refck,

How do you build it? yarn install && yarn package ? This fails for me due to an error:

error Package "node-video-lib" refers to a non-existing file '"/projects/Repos/refck_extension/node-video-lib@npm:2.2.1#./patches/node-video-lib-async.patch"'.

It seems to look for a folder "node-video-lib".

Another issue arises though, after installing the extension, foxglove-studio (v.1.72.0) returns in the panel:

This panel encountered an unexpected error
Something went wrong in this panel. Dismiss this error to continue using this panel. If the issue persists, try resetting the panel.

Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons: 1. You might have mismatching versions of React and the renderer (such as React DOM) 2. You might be breaking the Rules of Hooks 3. You might have more than one copy of React in the same app See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.
Show details

To fix this I need to set the react version to 17.0.2 in package.json. Do you encounter this issue too?

Thanks