codewithpassion / foxglove-studio-h264-extension

POC extension to render h264
MIT License
9 stars 5 forks source link

Update for ROS2 message. #6

Open dorton21 opened 9 months ago

dorton21 commented 9 months ago

To ensure the longevity and usefulness for the FoxGlove community, can this package be update with support for ROS2 messages? Specifically, sensor_msgs/msg/CompressedImage?

christian-nils commented 9 months ago

Hi @dorton21,

I tried to add it. I had a lot of troubles building the original package, for some reason, but after some tweaking it seems to be working. Please have a look to https://github.com/christian-nils/foxglove-studio-h264-extension, could you test and let me know if it works? I have added a new MCAP file, I converted the original ROS1 MCAP as I am not sure yet how you create the MCAP file based on a h264 video (this needs to be improved in the README.md file)

Thanks!

dorton21 commented 9 months ago

@christian-nils Thank you for the support around this! I'm looking forward to testing it this coming week.

dorton21 commented 9 months ago

@christian-nils I had an opportunity to test this. An example of one of the message being passed through is attached. I didn't see any images get successfully translated and displayed to the screen however. image

christian-nils commented 9 months ago

@dorton21 Did you try to play the new MCAP file in my repo? Did it work?