codex-semantics-library / patricia-tree

Patricia Tree data structure in OCaml for maps and sets, supports generic (GADT) keys
https://codex.top/api/patricia-tree/
GNU Lesser General Public License v2.1
13 stars 0 forks source link

Switch log2 #2

Closed dlesbre closed 6 months ago

dlesbre commented 6 months ago

Todo: check how this works with negative numbers

dlesbre commented 6 months ago

@mlemerre this should be ready to merge following your fix of int_builtins. Some points of note:

mlemerre commented 6 months ago

Except for the few commands, sounds good! I don't think the fix would introduces a noticeable slow down (but I am not sure the OCaml compiler can detect that this is just an unsigned comparison. Ideally we would have a primitive for this...). The names are not short but in the spirit of the library!