codex-storage / codex-contracts-eth

Ethereum smart contracts for Codex
Other
6 stars 9 forks source link

`Content.cid` should be `bytes` #107

Open AuHau opened 4 months ago

AuHau commented 4 months ago

https://github.com/codex-storage/codex-contracts-eth/blob/57e8cd5013325f05e16833a5320b575d32a403f3/contracts/Requests.sol#L26

markspanbroek commented 4 months ago

Agreed that this should be the CID in binary form, not in string form. But it should bytes instead of bytes32, because a CID has a variable length.