search

codex-storage / codex-contracts-eth

Ethereum smart contracts for Codex
Other
6 stars 9 forks source link

fix(Marketplace): ensure requests include ask with sufficient slots #163

Closed 0x-r4bbit closed 1 month ago

0x-r4bbit commented 1 month ago

There is a missing check in requestStorage() on whether the Request contains an Ask where its slots is > 0.

This allows for making storage request without slots. Not harmful but not a valid state of the system either.

This commit adds that check and a test with batteries included.

0x-r4bbit commented 1 month ago

Rebased on top of latest master, waiting for CI to be green (and double check prover), will then merge.