codex-storage / codex-contracts-eth

Ethereum smart contracts for Codex
Other
6 stars 9 forks source link

Introduce abstraction for dealing with time periods #29

Closed markspanbroek closed 1 year ago

markspanbroek commented 1 year ago

Extracts the logic from Proofs that deals with time periods into Periods.sol.

markspanbroek commented 1 year ago

Periods could also be a library instead of a contract, however secondPerPeriod would not be storable in the lib, instead it would need to be passed to periodOf

Yes, and also periodStart() and periodEnd() would need to have it passed to them. That's why I choose to make it a contract for now.