Closed benbierens closed 1 year ago
Have you tried to bump to latest? Would prefer to go forward then backward 😅
As I remember I also set node to v18.15.0
in my PR and it was done because of the known issue - hardhat compile randomly and quietly stops before compiling contracts #3877.
Looks like the issue was fixed in Hardaht v2.16.1.
In our package.json
we have the following
https://github.com/codex-storage/codex-contracts-eth/blob/b4e4897a37b60d6a9e189b58d4295e9a2d7b6b6a/package.json#L21
As I remember I also set node to
v18.15.0
in my PR and it was done because of the known issue - hardhat compile randomly and quietly stops before compiling contracts #3877.Looks like the issue was fixed in Hardaht v2.16.1.
In our
package.json
we have the following
Seems quite old, we should definitely bump it. Ot does look like it might be the root cause of the failed builds of the multiarch image?
It does look like it might be the root cause of the failed builds of the multiarch image?
Oh. sorry about the issue during the Demo :) I've watched it and added some comments.
It was about nim-codex:latest
and a temporary tag I've added for Ben to test how can we get the app version :roll_eyes:
And more notes about upgrading node and modules and results in the branch - bumb-hardhat-and-hardhat-deploy
"hardhat": "^2.17.1",
"hardhat-deploy": "^0.11.34"
node:18.17.0-alpine3.17
hardhat-deploy-ethers
)docker run --rm codexstorage/dist-tests-codex-contracts-eth:sha-d6fbfdc
@AuHau added a draft PR and we can consider that only after hardhat-waffle
package dependencies update - Ethers v6 support #65.
Now, we should probably go wit the changes proposed above.
codexstorage/dist-tests-codex-contracts-eth:sha-d6fbfdc
Passes test on local instance.
Passes test on cloud instance.
codexstorage/dist-tests-codex-contracts-eth:sha-d6fbfdc Passes test on local instance. Passes test on cloud instance.
I am bit confused. Is it with the changes from this PR or from Slava's branch?
Now, we should probably go wit the changes proposed above.
Agree, can you create PR and we can close this one in favor of this new PR?
Probably I will commit my changes in Ben's branch. Or it make sense to create a new PR?
Probably I will commit my changes in Ben's branch. Or it make sense to create a new PR?
I don't mind either ;-)
18.16 doesn't work reliably in the dist-test cloud environment. It works fine when the docker image is used on my local machine though. Very annoying.