codex-storage / codex-contracts-eth

Ethereum smart contracts for Codex
Other
6 stars 9 forks source link

chore: update dependencies #64

Closed benbierens closed 1 year ago

benbierens commented 1 year ago

18.16 doesn't work reliably in the dist-test cloud environment. It works fine when the docker image is used on my local machine though. Very annoying.

AuHau commented 1 year ago

Have you tried to bump to latest? Would prefer to go forward then backward 😅

veaceslavdoina commented 1 year ago

As I remember I also set node to v18.15.0 in my PR and it was done because of the known issue - hardhat compile randomly and quietly stops before compiling contracts #3877.

Looks like the issue was fixed in Hardaht v2.16.1.

In our package.json we have the following https://github.com/codex-storage/codex-contracts-eth/blob/b4e4897a37b60d6a9e189b58d4295e9a2d7b6b6a/package.json#L21

dryajov commented 1 year ago

As I remember I also set node to v18.15.0 in my PR and it was done because of the known issue - hardhat compile randomly and quietly stops before compiling contracts #3877.

Looks like the issue was fixed in Hardaht v2.16.1.

In our package.json we have the following

https://github.com/codex-storage/codex-contracts-eth/blob/b4e4897a37b60d6a9e189b58d4295e9a2d7b6b6a/package.json#L21

Seems quite old, we should definitely bump it. Ot does look like it might be the root cause of the failed builds of the multiarch image?

veaceslavdoina commented 1 year ago

It does look like it might be the root cause of the failed builds of the multiarch image?

Oh. sorry about the issue during the Demo :) I've watched it and added some comments. It was about nim-codex:latest and a temporary tag I've added for Ben to test how can we get the app version :roll_eyes:

veaceslavdoina commented 1 year ago

And more notes about upgrading node and modules and results in the branch - bumb-hardhat-and-hardhat-deploy

  1. I've updated just some modules
    "hardhat": "^2.17.1",
    "hardhat-deploy": "^0.11.34"
  2. I've updated node to the latest LTS release - Node.js 18.17.0 (Hydrogen/2023-07-18)
    node:18.17.0-alpine3.17
  3. Additional modules update fails and should be investigated (for example hardhat-deploy-ethers)
  4. Docker Build was triggered manually and result can be tested
    docker run --rm codexstorage/dist-tests-codex-contracts-eth:sha-d6fbfdc
veaceslavdoina commented 1 year ago

@AuHau added a draft PR and we can consider that only after hardhat-waffle package dependencies update - Ethers v6 support #65.

Now, we should probably go wit the changes proposed above.

benbierens commented 1 year ago

codexstorage/dist-tests-codex-contracts-eth:sha-d6fbfdc Passes test on local instance. Passes test on cloud instance.

AuHau commented 1 year ago

codexstorage/dist-tests-codex-contracts-eth:sha-d6fbfdc Passes test on local instance. Passes test on cloud instance.

I am bit confused. Is it with the changes from this PR or from Slava's branch?

Now, we should probably go wit the changes proposed above.

Agree, can you create PR and we can close this one in favor of this new PR?

veaceslavdoina commented 1 year ago

Probably I will commit my changes in Ben's branch. Or it make sense to create a new PR?

AuHau commented 1 year ago

Probably I will commit my changes in Ben's branch. Or it make sense to create a new PR?

I don't mind either ;-)