Closed AuHau closed 5 months ago
Should be good for another review now @AuHau & @emizzle.
LGTM! Pretty good work. Thanks for taking it over and finishing it! 👍 I can't approve my own PR, so somebody else needs to do that. 🤪
Thanks for the review, I'll just wait for @emizzle's review before merging.
Just a side note, there were a lot of formatting changes. It is kind of distracting for reviewing... Maybe in the future, we could adapt some aggressive styler like Prettier just for Solidity to prevent these in the future.
Good idea, try npm run format
:stuck_out_tongue_winking_eye:
I'm merging this, we can always update the code when we think of a better way to handle endianness.
This is a draft PR of my integration of the verifier, which I managed to get to before going to vacation. I managed to get to the basic integration point, but further work is needed to finish it.
The current state is that the Verifier is deployed and works with the generated proof that is part of the Circuit assets build here. The tests
Proofs.test.js
are passing (which was my personal goal), but the whole suite not yet.There are numerous TODOs spread around the changes to better indicate what needs to be finished, but the main high-level things are:
submitProof()
call