search

codex-storage / codex-contracts-eth

Ethereum smart contracts for Codex
Other
6 stars 9 forks source link

Increase proof period #88

Closed markspanbroek closed 7 months ago

markspanbroek commented 7 months ago

In Codex's integration tests we now create real ZK proofs, which take a bit longer to generate. We therefore need a period that remains the same while the proof is generated.

emizzle commented 7 months ago

I'm not sure that increasing the timeout will help with an increased proof generation time, as the validator is checking the previous period, so the timeout actually reflects how long the validator has to mark a proof as missing for the previous period.

If the validator were to generate proofs, then I do believe this should be increased.

markspanbroek commented 7 months ago

I'm not sure that increasing the timeout will help with an increased proof generation time

You're right, it doesn't help with that :smile: I just changed it to keep the timeout at the halfway mark of the period.