codex-storage / cs-codex-dist-tests

Distributed System Tests for Nim-Codex
4 stars 4 forks source link

Fix Dist-Tests workflow inputs #54

Closed veaceslavdoina closed 1 year ago

veaceslavdoina commented 1 year ago

Context

This PR fixe Dist-Tests workflow inputs. Looks like it fail to create the job, because Kubernetes unnecessarily requiring quoting on numeric env vars #82296.

TESTID: 6115366
Screenshot Screenshot 2023-09-06 at 19 16 20

Fix

We have at least 2 ways to fix that

  1. Update the manifest to quote the values
  2. Switch to the github.event.inputs instead of the inputs - Providing inputs

We started from the second option as an easiest way to fix that. In case of need we also will apply the first option.

Additional

It worked nice before and probably just by coincidence, because this is the first time 'short sha' is just a number.

Screenshot Screenshot 2023-09-06 at 19 27 58