search

codex-storage / nim-codex

Decentralized Durability Engine
https://codex.storage
Apache License 2.0
69 stars 25 forks source link

Fix: null-ref in networkPeer #937

Closed benbierens closed 1 month ago

benbierens commented 1 month ago

Please read #914

benbierens commented 1 month ago

I checked the other uses of .withValue and found no other situations where this same issue could occur. Reran the dist-tests I had set up to reproduce the issue and indeed this fixes it.

gmega commented 1 month ago

Since Dmitriy will be away for a bit, I'm going to dismiss his review so we can unblock this, and then I'd ask someone else (e.g. @markspanbroek?) to re-review it in light of the current discussion on his behalf.