Closed gmega closed 6 months ago
I feel like @emizzle might have some good input on this issue.
and will cause issues when both libraries are imported
There is no conflict here that I can see. The conversions in ethers are not exported outside the library that I can tell. Even if they were, from pkg/ethers import Address
should only import the Address
symbol from ethers, not the fromJson
symbol(s).
Fixed by #74
The post-chronos-v4 versions of nim-ethers introduce public json conversions which behave differently from the same conversions in nim-serde and will cause issues when both libraries are imported.
There are two ways to address this:
As far as I can tell, the only duplicate conversion that is present in both libraries is the conversion from UInt256, which allows empty strings in nim-ethers but does not allow them in nim-serde. I am therefore going to try to attempt to make those uniform, and then drop the duplicate on the nim-ethers side.