search

codex-storage / questionable

Elegant optional types for Nim
Other
115 stars 5 forks source link

Do not edit AST nodes, make a copy first #32

Closed markspanbroek closed 1 year ago

markspanbroek commented 1 year ago

Fixes error "typechecked nodes may not be modified"

dryajov commented 1 year ago

Any reason not to merge, this seems to resolve the issues https://github.com/codex-storage/nim-codex/pull/423

elcritch commented 1 year ago

I don't see any reason why not?

I was wondering yesterday if instead of copying the node ast, it'd be possible to change the typed to untyped but figured that had more risk of unanticipated behavior changes.

markspanbroek commented 1 year ago

Merged and released in 0.10.9