search

codex-team / action-check-domain

Watch SSL certs and registry date expiring for your domains
MIT License
38 stars 9 forks source link

Crash on a specific domain #6

Open danvy opened 8 months ago

danvy commented 8 months ago

Hello, I get a crash using a domain with a .to extension like https://aoz.to Here is the callstack TypeError: Cannot read properties of undefined (reading 'split') at Object.parseWhoIsData (/home/runner/work/_actions/codex-team/action-check-domain/v1/dist/index.js:1:10361) at /home/runner/work/_actions/codex-team/action-check-domain/v1/dist/index.js:1:70054 at /home/runner/work/_actions/codex-team/action-check-domain/v1/dist/index.js:1:57990 at Socket. (/home/runner/work/_actions/codex-team/action-check-domain/v1/dist/index.js:1:68499) at Socket.emit (node:events:513:28) at emitErrorNT (node:internal/streams/destroy:157:8) at emitErrorCloseNT (node:internal/streams/destroy:122:3) at processTicksAndRejections (node:internal/process/task_queues:83:21)

Lissy93 commented 8 months ago

I'm seeing this issue to, also on a .to domain (https://dashy.to) (workflow run logs here)

Seems WHOIS data is returned in a different format for some TLDs (like .to). This action uses node-whois which has had a similar issue raised on it (re: FurqanSoftware/node-whois#114). Actually, when I tried a WHOIS lookup, using my own whois lookup tool, and I'm also not able to get parsable data back, for either your .to domain, or my .to domain. Even whois.com fails to get full info

This ticket should probably be closed, and a new issue opened upstream on https://github.com/FurqanSoftware/node-whois package. Alternatively, submitting a PR here to switch the NPM package this action uses, to one which is able to handle .to domains (but I don't know of any)