search

codex-team / codex.shortcuts

Micro-library for dispatching keyboard shortcuts in Javascript
MIT License
49 stars 7 forks source link

Module doesnt check for each meta-key #2

Closed gohabereg closed 5 years ago

gohabereg commented 5 years ago

Steps:

  1. Register new shotcut for example CMD+Z and () => console.log('CMD+Z') as handler
  2. On the page use the shortcut CMD+SHIFT+Z

Expected: nothing should happened because registered shortcut is CMD+Z, not CMD+SHIFT+Z Actual: Handler is fired

khaydarov commented 5 years ago

fixed in https://github.com/codex-team/codex.shortcuts/pull/4