codex-team / editor.js

A block-style editor with clean JSON output
https://editorjs.io
Apache License 2.0
28.71k stars 2.08k forks source link

Handle the fork complety from github with a fixed build script 💡 #1283

Closed sos-productions closed 4 years ago

sos-productions commented 4 years ago

Hello all,

I noticed that github fork is not complete , paragraph is empty and make the build crash this is a github issue TS2307: Cannot find module '../tools/paragraph/dist/bundle'.

I suggest either inform that is required because paragraph is the default tool and install it manually from editor.js source cloned tree $ git clone https://github.com/editor-js/paragraph.git src/components/tools/paragraph or or better update package.json to fech it if missing or include the sources with editor.js

sos-productions commented 4 years ago

I updated the build_dev and build helpers script adding just behind the last line npm run-script ...: -----------8< COPY START ----------

plugin Paragraph is mandantory

DIR="src/components/tools/paragraph" if ! [ "$(ls -A $DIR)" ]; then git clone https://github.com/editor-js/paragraph.git src/components/tools/paragraph fi -----------8<---COPY END -------

hata6502 commented 4 years ago

https://www.chatwork.com/#!rid139624421 Editor.js uses git sub modules to src/components/tools/paragraph and more. It can be resolved by using yarn:

yarn install
yarn pull_tools
sos-productions commented 4 years ago

hata-さん, ありがとう !

neSpecc commented 4 years ago

Resolved

sos-productions commented 4 years ago

https://www.chatwork.com/#!rid139624421

Aniki, it requires permissions to join the chat - I searched by id it fails. I created an account there https://chatwork.com/sos-productions

hata6502 commented 4 years ago

@sos-productions Sorry! I mistaked the url. correct: https://editorjs.io/core-development