"Convert to" in i18n.messages.ui.popover missing

codex-team / editor.js

A block-style editor with clean JSON output

https://editorjs.io

Apache License 2.0

28.93k stars 2.09k forks source link

"Convert to" in i18n.messages.ui.popover missing #2786

Open Sozialarchiv opened 4 months ago

Sozialarchiv commented 4 months ago

In the i18n example "Convert to" is missing in i18n.messages.ui.popover. It is only mentioned in the toolbar.

https://github.com/codex-team/editor.js/blob/next/example/example-i18n.html#L202

And thanks a lot for this great editor!

ishon19 commented 4 months ago

Hey @neSpecc, I'd like to work on this issue! 👋

Sozialarchiv commented 4 months ago

There is another missing:

i18n.messages.blockTunes.delete.Click to delete

lucklyTime commented 4 months ago

I saw it in this place haha https://github.com/codex-team/editor.js/blob/next/src/components/i18n/locales/en/messages.json

blaqdog commented 2 months ago

In editorjs 2.30.5 this works: For tunes block:

messages: {
        ui: {
            "blockTunes": {...},
            "inlineToolbar": {...},
            "toolbar": {...},
            "popover": {
                "Filter": "Фильтр",
                "Nothing found": "Не найдено",
                "Convert to": "Конвертировать в"
            }
        },
...
}

For text selection:

messages: {
    ui: {...},
    toolNames: {...},
    tools: {
        ...
        "convertTo": {
            "Convert to": "Конвертировать в"
        },
        ...
    },
}

neSpecc commented 2 weeks ago