codex-team / task-manager

3 stars 2 forks source link

Added workspace settings layout #108

Closed Y-k-Y closed 2 years ago

Y-k-Y commented 2 years ago

Resolves #106

TatianaFomina commented 2 years ago
  1. When reloading workspace settings page workspace name disappears

https://user-images.githubusercontent.com/31101125/158620716-f5ea349f-4633-42cf-8bec-82039f561191.mov

  1. It's impossible to delete a team member
  2. New workspace name is not displayed until page is reloaded
  3. After new teammate is added teammates form should close (or at least be cleared)
Y-k-Y commented 2 years ago
  1. When reloading workspace settings page workspace name disappears

    Screen.Recording.2022-03-16.at.17.59.10.mov

  2. It's impossible to delete a team member
  3. New workspace name is not displayed until page is reloaded
  4. After new teammate is added teammates form should close (or at least be cleared)

I thought new issue will be created for deleting team member since #106 only mentioned about layout. Will fix them soon anyways.

Y-k-Y commented 2 years ago

I already pushed 2 commits that removing team member you can check that commits are pushed well on feature/workspace-settings-layout branch. I can't understand why that commits are not appeared on this pull request and don't know how to solve this issue maybe i should close this pull request and recreate another pull request?

Y-k-Y commented 2 years ago

There are small issues with deleting teammates:

  • ui is not updated when you delete the only teammate in the list. After page reload though the change can be seen.
  • list of teammates is 'jumping' when you delete an item

Other than that everything seems to be working

Fixed