search

codeyu / nanoid-net

.NET implementation of ai's nanoid
MIT License
493 stars 42 forks source link

Int32.LeadingZeroCount is not called on .NET 8 #22

Open go3323 opened 2 weeks ago

go3323 commented 2 weeks ago

The NET7_0 directive does not detect .NET 8 and above. This should be NET7_0_OR_GREATER instead.

This should be changed in two places:

https://github.com/codeyu/nanoid-net/blob/485c0093a727c94260e83fdab13d2ff4dc52a401/src/Nanoid/Nanoid.cs#L254

https://github.com/codeyu/nanoid-net/blob/485c0093a727c94260e83fdab13d2ff4dc52a401/src/Nanoid/Nanoid.cs#L301

mmdfmateus commented 2 days ago

curious on what's the impact of this