search

codezero-be / laravel-localized-routes

⭐️ A convenient way to set up and use localized routes in a Laravel app.
MIT License
505 stars 46 forks source link

Relying on autodiscovery to register dependencies #46

Closed mabdullahsari closed 3 years ago

mabdullahsari commented 3 years ago

Hi & merci voor de package :)

Are you willing to accept a PR that manually registers the package's dependencies in its service provider rather than relying on autodiscovery?

We have intentionally disabled autodiscovery in a monolith we're currently working on that serves multiple apps. But since the package does not manually register its own dependencies, we have to register 3 or 4 (not sure) service providers in each app to make the package work, which is quite cumbersome.

This should not break anything, just a convenience thing for the 1% that does not use autodiscovery 😄. The framework also skips registrations when a provider has already been registered.

ivanvermeyen commented 3 years ago

Hello,

I will gladly accept such a PR :)