search

codezjx / netease-cloud-music-dl

Netease cloud music song downloader, with full ID3 metadata, eg: front cover image, artist name, album name, song title and so on.
MIT License
495 stars 81 forks source link

add track no #57

Closed roadt closed 3 years ago

roadt commented 3 years ago

Hi codezjx, thanks for the project, it' helps a lot.

i find display order is not right in my ampache client, so I add track no to make it displaying correctly.

regards, Frank

codezjx commented 3 years ago

Hi @roadt, Thanks for your commit. I found frame TRCK represents the Track number/Position in set. Does it mean just a single track number? eg: text=str(song['no']), can you try this in your ampache client? Thanks a lot.

https://en.wikipedia.org/wiki/ID3

roadt commented 3 years ago

@codezjx thanks for response!

i was analyzing a valid mp3 file, and it contains "3/8"-like value. it works in my ampache client.

In https://id3.org/id3v2.3.0 , there is a description about 3/8 form.

TRCK The 'Track number/Position in set' frame is a numeric string containing the order number of the audio-file on its original recording. This may be extended with a "/" character and a numeric string containing the total numer of tracks/elements on the original recording. E.g. "4/9".

it should work, but not sure whether it's the best .

codezjx commented 3 years ago

@roadt ok, merged to the master branch. Thanks for your contribute!

roadt commented 3 years ago

a pleasure