codezonediitj / adaboost

Implementation of AdaBoost Algorithm

Other

9 stars 16 forks source link

Relocated "fill*" methods #13

Closed bits2zbytes closed 4 years ago

bits2zbytes commented 4 years ago

10

Removed fill method from the matrix and vector classes present in data structures.hpp , data_structures_impl.cpp,cuda_data_structures.hpp and cuda_data_structures_impl.hpp moved them to operations.hpp and operations_impl.cpp.

Also removed multiply, product functions from data structures.hpp and data_structures_impl.cpp and moved them to operations.hpp and operations_impl.cpp.

Added comments to the re-located functions.

czgdp1807 commented 4 years ago

Tests should be modified(the functions are shifted, so appropriate updates should be made there as well). The instantiated template files are also required to be updated. You can run tests locally using, cmake -DBUILD_TESTS=ON -DINSTALL_GOOGLETEST=ON [path to adaboost repository on your system]. Ensure that you run this command in a new directory different from that of the repo. Then go to bin folder and run the test files, ./name_of_the_test_file. Install appropriate version of cmake.

czgdp1807 commented 4 years ago

Closing in favour of #27