search

codezonediitj / adaboost

Implementation of AdaBoost Algorithm
Other
9 stars 16 forks source link

CUDA libraries are installed even if they aren't built #25

Closed czgdp1807 closed 4 years ago

czgdp1807 commented 4 years ago

Description of the problem

libbnn_cuda* files are installed even if they aren't built. See, https://github.com/codezonediitj/adaboost/blob/5164fea84e136cd12074c16abb8e85e853faacce/CMakeLists.txt#L46-L51

A minor check is needed to fix this,

if(BUILD_CUDA)
    install(...)
endif()

The above is just a hint not a complete solution.

Example of the problem

References/Other comments

purva98 commented 4 years ago

Hello, @czgdp1807 me and my teammate would love to work on this issue!

czgdp1807 commented 4 years ago

Sure. Please proceed with a PR for the fix.

Vi1i commented 4 years ago

Hi @czgdp1807, do you have preference over generator-expressions or if statement blocks for the control?

Vi1i commented 4 years ago

Hi @czgdp1807, do you have preference over generator-expressions or if statement blocks for the control?

Never mind, for the generator expression to work with OFF/ON needs a new version of cmake.