codezonediitj / pydatastructs

A python package for data structures and algorithms

https://pydatastructs.readthedocs.io/en/stable/

Other

202 stars 270 forks source link

[WIP] Added Longest Common Sequence #310

Closed LazarusCoder closed 3 years ago

LazarusCoder commented 3 years ago

References to other Issues or PRs or Relevant literature

Fixes #308 #310

Brief description of what is fixed or changed

Longest Common Subsequence #308 is been added with backtracking so now we get the Lenght of LCS and sequence too

Other comments

czgdp1807 commented 3 years ago

Please go through some already present code in master. The code is okay but the function names aren't descriptive, the document string isn't following the already existing style. Code quality checks are failing.

codecov[bot] commented 3 years ago

Codecov Report

Merging #310 (9643882) into master (42832f7) will increase coverage by 0.008%. The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master      #310       +/-   ##
=============================================
+ Coverage   98.866%   98.874%   +0.008%     
=============================================
  Files           25        25               
  Lines         2999      3021       +22     
=============================================
+ Hits          2965      2987       +22     
  Misses          34        34

Impacted Files	Coverage Δ
pydatastructs/linear_data_structures/__init__.py	`100.000% <ø> (ø)`
pydatastructs/linear_data_structures/algorithms.py	`99.507% <100.000%> (+0.059%)`	:arrow_up:

LazarusCoder commented 3 years ago

LCS with Back Tracking Done

sidhu1012 commented 3 years ago

Please go through some already present code in master. The code is okay but the function names aren't descriptive, the document string isn't following the already existing style.

These issues still persist in code. Please make function name more informative and follow numpy docstring guidelines.

LazarusCoder commented 3 years ago

Please go through some already present code in master. The code is okay but the function names aren't descriptive, the document string isn't following the already existing style.

These issues still persist in code. Please make function name more informative and follow numpy docstring guidelines. @czgdp1807 right now function name is LCS =>Longest common sub sequence would be big as a function name same while calling it dont you think?

czgdp1807 commented 3 years ago

Care to add some spaces around =, after, ,. It just makes it easier to read code.

sidhu1012 commented 3 years ago

It has conflicts now. Please resolve them.

czgdp1807 commented 3 years ago

Closing in favour of https://github.com/codezonediitj/pydatastructs/pull/315