codezonediitj / pydatastructs

A python package for data structures and algorithms
https://pydatastructs.readthedocs.io/en/stable/
Other
201 stars 267 forks source link

Do not invoke setupy.py directly. #418

Closed Carreau closed 2 years ago

Carreau commented 2 years ago

invoking setup.py directly is not the best way to install a package from source. See one of the most recent blog about this:

https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html

This updates the readme to invoke pip, and use python -m pip to make sure that the pip which is invoked is the one from the current Python.

i'm also happy to make it python3 -m pip, but these days python points to python 3 most of the time.

References to other Issues or PRs or Relevant literature

Brief description of what is fixed or changed

Other comments

codecov[bot] commented 2 years ago

Codecov Report

Merging #418 (29adc2c) into master (6246354) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #418   +/-   ##
=========================================
  Coverage   98.611%   98.611%           
=========================================
  Files           27        27           
  Lines         3530      3530           
=========================================
  Hits          3481      3481           
  Misses          49        49           

Impacted file tree graph

czgdp1807 commented 2 years ago

Thanks for the PR.