Open HarshCasper opened 2 years ago
Merging #443 (4e57732) into master (f82f52d) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #443 +/- ##
=========================================
Coverage 98.588% 98.588%
=========================================
Files 29 29
Lines 3754 3754
=========================================
Hits 3701 3701
Misses 53 53
Is poetry.lock
file necessary. It has a lot of lines.
Hi @czgdp1807
This is my first attempt at migrating the project to Poetry. Please have a look and let me know the apt changes required. Based on my guesswork, these are the things that would be left:
setup.py
and requirements.txt
Is
poetry.lock
file necessary. It has a lot of lines.
It is required to lock all the developers to the same set of dependencies as everyone else is using. More about this on the Docs here: https://python-poetry.org/docs/basic-usage/#installing-with-poetrylock
Can we reduce the dependencies there then? We only use the following. Python should be a minimum of 3.8 from 1.0.1.
sphinx==4.2.0
sphinx-readable-theme==1.3.0
myst_nb==0.13.1
codecov
pytest-cov
- Removing
setup.py
andrequirements.txt
Let's keep setuptools
there. Some new contributors might not know about poetry so having setuptools
will help them. Having poetry
is also good for those who want to try something new or not really that into setuptools
.
I would suggest having two workflows, one using setuptools
and the other using poetry
. Meanwhile this should also be fixed, #453
Description
This PR: