codezonediitj / pydatastructs

A python package for data structures and algorithms
https://pydatastructs.readthedocs.io/en/stable/
Other
201 stars 267 forks source link

Added Selection sort and Insertion sort algorithm #462

Closed youknowqyh closed 2 years ago

youknowqyh commented 2 years ago

References to other Issues or PRs or Relevant literature

Brief description of what is fixed or changed

Other comments

codecov[bot] commented 2 years ago

Codecov Report

Merging #462 (73ec50e) into master (c0d2786) will increase coverage by 0.011%. The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master      #462       +/-   ##
=============================================
+ Coverage   98.549%   98.560%   +0.011%     
=============================================
  Files           29        29               
  Lines         3792      3822       +30     
=============================================
+ Hits          3737      3767       +30     
  Misses          55        55               
Impacted Files Coverage Δ
pydatastructs/linear_data_structures/__init__.py 100.000% <ø> (ø)
pydatastructs/linear_data_structures/algorithms.py 99.781% <100.000%> (+0.015%) :arrow_up:

Impacted file tree graph

czgdp1807 commented 2 years ago

Please make sure you pull the changes from sortalgo (your branch for this PR) before pushing back anything.

youknowqyh commented 2 years ago

Please make sure you pull the changes from sortalgo (your branch for this PR) before pushing back anything.

Sure!

youknowqyh commented 2 years ago

Is there any issue about this?

czgdp1807 commented 2 years ago

I will merge this on Sunday after pushing some polishing commits to your branch.

youknowqyh commented 2 years ago

I will merge this on Sunday after pushing some polishing commits to your branch.

Thanks for your guiding! I'll continue reading the source code and contribute something else in this project :)

czgdp1807 commented 2 years ago

I'll continue reading the source code and contribute something else in this project

It would be great if you can take a look at the open issues as well. There is a lot of stuff we need help with.

youknowqyh commented 2 years ago

I'll continue reading the source code and contribute something else in this project

It would be great if you can take a look at the open issues as well. There is a lot of stuff we need help with.

Yeah sure!

czgdp1807 commented 2 years ago

Thanks @youknowqyh