Open CarolLuca opened 1 year ago
I would recommend to always shift to a new branch (other than main
before making a new PR). Right now you have made your PR using your main
branch. Keep this PR as is but from next time onwards update your main
locally and then switch to a new branch for a new feature/bug fix.
Merging #524 (b8c6b45) into main (2482adb) will increase coverage by
0.045%
. The diff coverage is100.000%
.
See, https://app.codecov.io/gh/codezonediitj/pydatastructs/pull/524/blob/pydatastructs/strings/suffix_tree.py. There are lots of lines (see the red ones) which aren't tested.
Also add SuffixTree
to the following list,
I followed all the requested changes and added more tests such that the testing covers all the methods and sub-cases. I would be grateful if you could tell me if I can polish the classes in any other way.
Thanks for this. Sorry for the later review. Mostly related to documentation.
I combined the __new__
and __init__
methods successfully, and added documentation for the main class, but also for the auxiliary classes from misc_util.py
References to other Issues or PRs or Relevant literature
Brief description of what is fixed or changed
Added suffix tree class
Other comments
May be considered as GSoC 23 work sample