codezonediitj / pydatastructs

A python package for data structures and algorithms
https://pydatastructs.readthedocs.io/en/stable/
Other
199 stars 270 forks source link

Add CPP version of bubble sort #540

Closed sak-codes closed 11 months ago

sak-codes commented 12 months ago

References to other Issues or PRs or Relevant literature

Brief description of what is fixed or changed

Other comments

codecov[bot] commented 12 months ago

Codecov Report

Merging #540 (d015620) into main (0dabe35) will increase coverage by 0.001%. The diff coverage is 100.000%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #540 +/- ## ============================================= + Coverage 97.594% 97.595% +0.001% ============================================= Files 34 34 Lines 4281 4283 +2 ============================================= + Hits 4178 4180 +2 Misses 103 103 ``` | [Impacted Files](https://app.codecov.io/gh/codezonediitj/pydatastructs/pull/540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codezonediitj) | Coverage Δ | | |---|---|---| | [pydatastructs/linear\_data\_structures/algorithms.py](https://app.codecov.io/gh/codezonediitj/pydatastructs/pull/540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codezonediitj#diff-cHlkYXRhc3RydWN0cy9saW5lYXJfZGF0YV9zdHJ1Y3R1cmVzL2FsZ29yaXRobXMucHk=) | `99.783% <100.000%> (+<0.001%)` | :arrow_up: | [![Impacted file tree graph](https://app.codecov.io/gh/codezonediitj/pydatastructs/pull/540/graphs/tree.svg?width=650&height=150&src=pr&token=mZMqq5ubAu&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codezonediitj)](https://app.codecov.io/gh/codezonediitj/pydatastructs/pull/540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codezonediitj)
czgdp1807 commented 11 months ago

When doing benchmarks, the CI on ubuntu goes out of memory and seems like the operation gets cancelled.

czgdp1807 commented 11 months ago

Or I forgot, bubble sort is O(n^2), so it is supposed to be ~4 times slower when on size 4000 so probably CI times out.