codezonediitj / pydatastructs

A python package for data structures and algorithms
https://pydatastructs.readthedocs.io/en/stable/
Other
202 stars 270 forks source link

Add CPP version of selection sort #542

Closed sak-codes closed 1 year ago

sak-codes commented 1 year ago

References to other Issues or PRs or Relevant literature

Closes #541

Brief description of what is fixed or changed

Other comments

sak-codes commented 1 year ago

I have renamed the old file so that we can add all O(n**2) sort algorithms under the same file.

codecov[bot] commented 1 year ago

Codecov Report

Merging #542 (86c1b94) into main (674fc62) will increase coverage by 0.001%. The diff coverage is 100.000%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #542 +/- ## ============================================= + Coverage 97.595% 97.596% +0.001% ============================================= Files 34 34 Lines 4283 4285 +2 ============================================= + Hits 4180 4182 +2 Misses 103 103 ``` | [Impacted Files](https://app.codecov.io/gh/codezonediitj/pydatastructs/pull/542?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codezonediitj) | Coverage Δ | | |---|---|---| | [pydatastructs/linear\_data\_structures/algorithms.py](https://app.codecov.io/gh/codezonediitj/pydatastructs/pull/542?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codezonediitj#diff-cHlkYXRhc3RydWN0cy9saW5lYXJfZGF0YV9zdHJ1Y3R1cmVzL2FsZ29yaXRobXMucHk=) | `99.784% <100.000%> (+<0.001%)` | :arrow_up: | | [pydatastructs/utils/testing\_util.py](https://app.codecov.io/gh/codezonediitj/pydatastructs/pull/542?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codezonediitj#diff-cHlkYXRhc3RydWN0cy91dGlscy90ZXN0aW5nX3V0aWwucHk=) | `18.518% <100.000%> (ø)` | | [![Impacted file tree graph](https://app.codecov.io/gh/codezonediitj/pydatastructs/pull/542/graphs/tree.svg?width=650&height=150&src=pr&token=mZMqq5ubAu&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codezonediitj)](https://app.codecov.io/gh/codezonediitj/pydatastructs/pull/542?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codezonediitj)
sak-codes commented 1 year ago

The failing test is fixed. Please review.

czgdp1807 commented 1 year ago

What was the issue by the way?

sak-codes commented 1 year ago

Thank you for merging. The issue was an incorrect root path.