search

codiak / socialarchive-dapp

Dapp built on Swarm to back-up and interact with Twitter data.
GNU General Public License v3.0
2 stars 3 forks source link

GetLogin integration and archive upload #88

Closed ginanisque closed 2 years ago

netlify[bot] commented 2 years ago

Deploy Preview for optimistic-heisenberg-d06a80 ready!

Name Link
Latest commit a78b3bac5c40a687479ad9058748184417882804
Latest deploy log https://app.netlify.com/sites/optimistic-heisenberg-d06a80/deploys/63647a807109e20008a1f4e0
Deploy Preview https://deploy-preview-88--optimistic-heisenberg-d06a80.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codiak commented 2 years ago

Changes to this PR will be auto-deployed to a preview site now! Thank you for your work on this.

ginanisque commented 2 years ago
Hello. I made some more fixes to the repository. Pls check it. https://github.com/ginanisque/socialarchive-dapp. Also I am not able to submit on Gitcoin. The bounty is expired on Gitcoin. I included a link to the demo  video on the bounty GitHub issue page.   Sent from Mail for Windows From: Cody PSent: Monday, 3 October 2022 10:21 amTo: codiak/socialarchive-dappCc: ginanisque; AuthorSubject: Re: [codiak/socialarchive-dapp] GetLogin integration and archive upload (PR #88) Changes to this PR will be auto-deployed to a preview site now! Thank you for your work on this.Cody—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***> 
codiak commented 2 years ago

@ginanisque Looks like you may need to update packages to get the build to pass and deploy a preview. Could you try rebasing on the latest main branch? It should have all the latest updates.

ginanisque commented 2 years ago

Ok, will do.

On Wed, 19 Oct 2022, 1:35 am Cody P, @.***> wrote:

@ginanisque https://github.com/ginanisque Looks like you may need to update packages to get the build to pass and deploy a preview. Could you try rebasing on the latest main branch? It should have all the latest updates.

— Reply to this email directly, view it on GitHub https://github.com/codiak/socialarchive-dapp/pull/88#issuecomment-1283182023, or unsubscribe https://github.com/notifications/unsubscribe-auth/AREWJ5QFG5PQWTTWW6JTID3WD465JANCNFSM6AAAAAAQ3HJA3U . You are receiving this because you were mentioned.Message ID: @.***>

codiak commented 2 years ago

Latest build failure is:

7:12:17 AM: Failed to compile.
7:12:17 AM: 
7:12:17 AM: Module not found: Error: Can't resolve '@ethersphere/bee-js' in '/opt/build/repo/client/src/utils'
7:12:18 AM: error Command failed with exit code 1. (https://ntl.fyi/exit-code-1)

You'll need to replace "@ethersphere" with "@fairDataSociety" to fix the imports

ginanisque commented 2 years ago

Hey. I hope you review this soon. Thanks.

ginanisque commented 2 years ago

It looks like the checks have passed. I am wondering if there are any other questions, concerns or issues before approval?

codiak commented 2 years ago

@ginanisque Before we merge we have a couple of things to take care of. A few of our concerns are:

Is there a time we could meet this weekend or next week? And could you use something like https://www.websequencediagrams.com/ to illustrate the GetLogin integration with Social Archive login flow?

We'd like to do a live code review, and merge your changes together while reviewing, then we can finalize this bounty, and move on to the next!