codice / ddf

DDF Distributed Data Framework - an open source, modular integration framework.
http://ddf.codice.org
Other
132 stars 181 forks source link

[2.19.x] DDF-6618 / G-9917 Adds proper namespace support to CSW GetRecordsMess… #6619

Closed jlcsmith closed 3 years ago

jlcsmith commented 3 years ago

…ageBodyReader

What does this PR do?

Fixes a bug with the CSW Source in the case that the CSW server sends back a GetRecordsResponse with a non-"csw" namespace prefix. Now the MessageBodyReader properly handles namespace prefix mappings.

Who is reviewing it?

@jrnorth @millerw8 @maiiiiiiii

Select relevant component teams:

@codice/data @codice/ogc

Ask 2 committers to review/merge the PR and tag them here.

@jrnorth @millerw8

How should this be tested?

This condition is covered by the newly added unit tests. So a successful CI should be sufficient.

Any background context you want to provide?

What are the relevant tickets?

Fixes: #6618

Screenshots

Checklist:

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

jlcsmith commented 3 years ago

build now

cxddfbot commented 3 years ago

Internal build has been started, your results will be available at build completion.

cxddfbot commented 3 years ago

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

cxddfbot commented 3 years ago

Internal build has been started, your results will be available at build completion.

cxddfbot commented 3 years ago

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

cxddfbot commented 3 years ago

Internal build has been started, your results will be available at build completion.

cxddfbot commented 3 years ago

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

jlcsmith commented 3 years ago

build now

cxddfbot commented 3 years ago

Internal build has been started, your results will be available at build completion.

cxddfbot commented 3 years ago

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

cxddfbot commented 3 years ago

Internal build has been started, your results will be available at build completion.

cxddfbot commented 3 years ago

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

jlcsmith commented 3 years ago

build now

cxddfbot commented 3 years ago

Internal build has been started, your results will be available at build completion.

cxddfbot commented 3 years ago

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

jlcsmith commented 3 years ago

Full build passed. Hero'd with @kcwire by using a CSW server returning non "csw" namespace prefixes.