[2.19.x] G-9945 Allow empty location in search forms

jrnorth commented 3 years ago

What does this PR do?

This allows a search form to require a location without having to specify the location type, allowing the user to select their own when running a search.

Who is reviewing it?

@kcwire @jMoneee

Select relevant component teams:

@codice/ui

Ask 2 committers to review/merge the PR and tag them here.

@andrewzimmer @millerw8

How should this be tested?

Create a search form and add either the anyGeo or location field, or both. Do not select a location option. Verify no warnings are displayed and that you can save the search form.

Open a workspace and use the search form. Verify you can select a location option and that your search works as expected.

Use the advanced search and add either the anyGeo or location field, or both. Verify you are warned to select a location, and that you cannot run the search without selecting a location option.

Screenshots

Before

https://user-images.githubusercontent.com/4495447/134585250-486cf8b5-ec0e-4c11-9d5b-9b7abe654e74.mp4

After

https://user-images.githubusercontent.com/4495447/134585909-74e37b26-edf9-4248-a108-01cb52ffcb48.mp4

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

jlcsmith commented 3 years ago

build now

cxddfbot commented 3 years ago

Internal build has been started, your results will be available at build completion.

jlcsmith commented 3 years ago

🎉 Hero Success 🎉 Verified search forms can be created with empty locations, dates and text fields without issue. Verified the UI requires that search geometries be non-empty when submitting the search.

cxddfbot commented 3 years ago

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

codice / ddf