Closed jrnorth closed 2 years ago
build now
Internal build has been started, your results will be available at build completion.
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.
build now
Internal build has been started, your results will be available at build completion.
Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.
Internal build has been started, your results will be available at build completion.
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.
Did a quick verification with the additional UI changes. Validated that the geo wrapping issue is no longer occurring in the 2D map. Also re-verified the overlay functionality
What does this PR do?
Adds a new option to the overlay metacard transformer that, when enabled, normalizes each overlay's orientation by matching the upper-left and upper-right corners of the image to the left and right vertices of the polygon's northern edge, respectively.
Select relevant component teams:
@codice/core-apis @codice/io
Ask 2 committers to review/merge the PR and tag them here.
@jlcsmith @kcwire @millerw8
How should this be tested?
Ingest this sample record, or any record with a rectangular WKT and a thumbnail. Verify that without enabling the option, the top edge of the image is aligned with the 'top' (not 'northern') edge of the rectangle (the top edge of the rectangle is the edge with the WKT's first two points). When the option is enabled, verify the top edge of the image is aligned with the northern edge of the rectangle. See the screenshots for an example.
On the 2D map, draw various lines across the date line and verify they do not wrap the other way around the world.
Do the same with polygons.
Ingest some metacards with various types of locations, like lines, multilines, polygons, and multipolygons, across the date line and verify that when you search for them and they are displayed on the map that they do not wrap the other way around the world.
Ingest some metacards with a polygon location across the dateline and a thumbnail. Overlay the image on the map and verify the image does not wrap the other way around the world.
Screenshots
Orientation Normalization Disabled
Orientation Normalization Enabled
2D Line Drawing Across Dateline Before
2D Line Drawing Across Dateline After
2D Polygon Drawing Across Dateline Before
2D Polygon Drawing Across Dateline After
Overlay Across Dateline Before
Overlay Across Dateline After
Checklist
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: