Fix unregistering a BrandingPlugin from BrandingRegistry

pklinef commented 2 years ago

What does this PR do?

Fixes an exception that happens if a BrandingPlugin is unregistered from the BrandingRegistry.

branding-registry-impl [org.osgi.framework.FrameworkEvent] ERROR : FrameworkEvent ERROR
java.lang.ClassCastException: class org.codice.ddf.branding.impl.DdfBrandingPlugin cannot be cast to class org.osgi.framework.ServiceReference (org.codice.ddf.branding.impl.DdfBrandingPlugin is in unnamed module of loader org.eclipse.osgi.internal.loader.EquinoxClassLoader @ae9129f; org.osgi.framework.ServiceReference is in unnamed module of loader 'app')
    at org.codice.ddf.branding.impl.BrandingRegistryImpl$1.compare(BrandingRegistryImpl.java:44)
    at java.base/java.util.TreeMap.getEntryUsingComparator(TreeMap.java:374)
    at java.base/java.util.TreeMap.getEntry(TreeMap.java:343)
    at java.base/java.util.TreeMap.remove(TreeMap.java:601)
    at java.base/java.util.Collections$SynchronizedMap.remove(Collections.java:2601)
    at org.codice.ddf.branding.impl.BrandingRegistryImpl$BrandingListener.serviceChanged(BrandingRegistryImpl.java:141)

Who is reviewing it?

Select relevant component teams:

Ask 2 committers to review/merge the PR and tag them here.

@ahoffer @ryeats

How should this be tested?

Verify CI passes

Any background context you want to provide?

What are the relevant tickets?

Fixes: n/a

Screenshots

Checklist:

[ ] Documentation Updated
[ ] Update / Add Threat Dragon models
[ ] Update / Add Unit Tests
[ ] Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

pklinef commented 2 years ago

build now

cxddfbot commented 2 years ago

Internal build has been started, your results will be available at build completion.