The User.Preferences model will now convert old-style CQL result filters to filter trees on the fly.
Who is reviewing it?
@millerw8
@kcwire
@shaundmorris
How should this be tested?
Open the Solr Admin UI and query the preferences core.
Copy the preferences_json_bin for your user.
Base64 decode that string to a JSON file and create a resultFilter key with a CQL string value if no such key exists, or replace the existing value with a CQL string value.
a. The CQL string can be as simple as (\"anyText\" ILIKE ''), or it can be a more complex query.
Base64 encode that JSON file and update your user preferences via the Documents page in the Solr Admin UI, filling in the ID of your preferences and your base64-encoded JSON:
Open Intrigue, click on your result filter, and verify that the CQL you added in step 3 was parsed correctly into the result filter.
Run some queries and verify your results appear to be filtered correctly by the result filter.
Checklist:
[ ] Documentation Updated
[ ] Update / Add Threat Dragon models
[x] Update / Add Unit Tests
[ ] Update / Add Integration Tests
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend:
✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.
What does this PR do?
The User.Preferences model will now convert old-style CQL result filters to filter trees on the fly.
Who is reviewing it?
@millerw8 @kcwire @shaundmorris
How should this be tested?
preferences
core.preferences_json_bin
for your user.resultFilter
key with a CQL string value if no such key exists, or replace the existing value with a CQL string value. a. The CQL string can be as simple as(\"anyText\" ILIKE '')
, or it can be a more complex query.Documents
page in the Solr Admin UI, filling in the ID of your preferences and your base64-encoded JSON:Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: