codice / ddf

DDF Distributed Data Framework - an open source, modular integration framework.
http://ddf.codice.org
Other
132 stars 181 forks source link

[2.19.x] G-10041 Add support for old CQL result filters #6683

Closed jrnorth closed 2 years ago

jrnorth commented 2 years ago

What does this PR do?

The User.Preferences model will now convert old-style CQL result filters to filter trees on the fly.

Who is reviewing it?

@millerw8 @kcwire @shaundmorris

How should this be tested?

  1. Open the Solr Admin UI and query the preferences core.
  2. Copy the preferences_json_bin for your user.
  3. Base64 decode that string to a JSON file and create a resultFilter key with a CQL string value if no such key exists, or replace the existing value with a CQL string value. a. The CQL string can be as simple as (\"anyText\" ILIKE ''), or it can be a more complex query.
  4. Base64 encode that JSON file and update your user preferences via the Documents page in the Solr Admin UI, filling in the ID of your preferences and your base64-encoded JSON: Screen Shot 2022-02-16 at 5 59 50 PM
  5. Open Intrigue, click on your result filter, and verify that the CQL you added in step 3 was parsed correctly into the result filter.
  6. Run some queries and verify your results appear to be filtered correctly by the result filter.

Checklist:

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

jrnorth commented 2 years ago

build now

cxddfbot commented 2 years ago

Internal build has been started, your results will be available at build completion.

cxddfbot commented 2 years ago

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

maiiiiiiii commented 2 years ago

hero successful!

updating_preferences_solr ui