search

codice / ddf

DDF Distributed Data Framework - an open source, modular integration framework.
http://ddf.codice.org
Other
132 stars 181 forks source link

G-10122 Fix issues related to geometry buffering #6691

Closed jrnorth closed 2 years ago

jrnorth commented 2 years ago

What does this PR do?

Select relevant component teams:

@codice/solr

Ask 2 committers to review/merge the PR and tag them here.

@jlcsmith @kcwire @millerw8

How should this be tested?

  1. Run gazetteer:update with https://github.com/codice/ddf/blob/03be912e331024f3bc6856d5e87f8e3b7db0b392/distribution/ddf-common/src/main/resources/data/countries.geo.json
  2. Run gazetteer:build-suggester-index
  3. Ingest the following files: russia1.json 
    {
"type": "Feature",
"geometry": {
"type": "Point",
"coordinates": [-179.9375, 69.116389]
},
"properties": {
"title": "Russia 1"
}
}

    russia2.json

    {
"type": "Feature",
"geometry": {
"type": "Point",
"coordinates": [179.900833, 71.637778]
},
"properties": {
"title": "Russia 2"
}
}

    These locations are both within a 25km buffer of the Russia polygon, close to the antimeridian.

  4. Open Intrigue and create an anyGeo query with the keyword 'Russia'. Run it and verify you get no results.
  5. Add a buffer of 25km and verify you get both results.

Checklist:

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

jrnorth commented 2 years ago

build now

cxddfbot commented 2 years ago

Internal build has been started, your results will be available at build completion.

cxddfbot commented 2 years ago

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

jrnorth commented 2 years ago

build now

cxddfbot commented 2 years ago

Internal build has been started, your results will be available at build completion.

cxddfbot commented 2 years ago

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

jrnorth commented 2 years ago

build now

cxddfbot commented 2 years ago

Internal build has been started, your results will be available at build completion.

cxddfbot commented 2 years ago

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

jlcsmith commented 2 years ago

Verified -